Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Heroku deploy #26

Merged
merged 7 commits into from
Feb 14, 2017
Merged

Clean up Heroku deploy #26

merged 7 commits into from
Feb 14, 2017

Conversation

daaray
Copy link
Contributor

@daaray daaray commented Feb 12, 2017

Fixes #3

Breaking out S3 static/media support into a separate ticket as it requires additional configuration.

@hminnovation
Copy link
Contributor

This all looks good from my perspective. Should we add something to the readme as well though? Since the Heroku requirements won't get loaded till someone runs pip install -r requirements/heroku.txt it'd be good to make that explicit. Perhaps we should add a Deployment to Heroku bit to the readme?

@daaray
Copy link
Contributor Author

daaray commented Feb 14, 2017

@heymonkeyriot thanks for the feedback. Will adjust accordingly.

@daaray daaray merged commit 1b8f29b into master Feb 14, 2017
@daaray daaray deleted the 3-heroku branch February 15, 2017 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants