Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

match supported wagtail versions and update test settings #31

Merged
merged 1 commit into from Sep 16, 2018

Conversation

Projects
None yet
2 participants
@falseperfection
Copy link
Contributor

commented Jun 29, 2018

https://github.com/wagtail/wagtail#compatibility

  • Python 3.4, 3.5, 3.6
  • Django 1.11, 2.0
@falseperfection

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2018

@robmoorman - I was looking at using django-bakery in wagtail and found this repo. I had to make a few tweaks to get tests passing, but otherwise this branch was working for me. Is this still in active development?

@loicteixeira

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2018

Thank you for your contribution @falseperfection.

FWIW, this package currently supports Wagtail 1.6 which means that it should still support Django 1.8 (see Compatible Django/Python versions) which this PR removes tests for. However, we this will probably soon change (I'll open an issue for that later) and for the sake of getting a new version out of the door, I'll go ahead with those changes. Thanks again.

Edit: Arg, I don't have sufficient permissions to merge this just yet. Working on getting this sorted and I will continue the work.
Edit 2: That was fast! Merging!

@loicteixeira loicteixeira merged commit 5eefb5d into wagtail:wagtail-2.0 Sep 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on failing-tests at 73.423%
Details

loicteixeira added a commit that referenced this pull request Sep 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.