Updates to the streamfield spacing mixin and subsequent adjustments #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o individual elements.
|
If there is any fontend dev (more experienced than me) that can have a look at this change would be nice. Otherwise seems ok to me... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spacing between StreamField blocks was too large and making our blog pages look a little funny. I initially removed the media query in
@mixin sf-spacing()but that broke the spacing around the hero areas and other elements. So I updatedsf-spacingto include a variable$multiplethat could be used to adjust spacing for individual elements in multiples of 25px. Then I updated all selectors that use that mixin according to the amount of space needed for each element.I also removed a media-query the
.icon-bulletselector since that needed adjustment as well.Please let me know if there's anything I can do to improve this adjustment to the spacing.