New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Streamfield UI changes #3942

Closed
wants to merge 45 commits into
base: master
from

Conversation

@heymonkeyriot
Contributor

heymonkeyriot commented Oct 19, 2017

Ready for review.

These are iterative amends towards the longer term desire to improve the look and feel of StreamField. From the Bristol sprint.

Needs to:

  • Present nested streamfields up to 4-levels deep in a usable way
  • Make it clearer to users what the block-type is
  • Make controls visible at all times
  • Make it clearer to users the separation between blocks
  • Consistently style different blocks
  • Consistently style user-input content (except regex and HTML blocks)
  • Style regex and HTML blocks to reflect manner of input
  • Improve visual flow of StreamField elements
  • Consistent spacing regardless of whether StreamBlock nested in StructBlock etc.
  • Improve look and feel of StreamMenu
  • Pass CI tests / linting
  • Test across many different instances of Wagtail

Closes #2325

@gasman

This comment has been minimized.

Show comment
Hide comment
@gasman

gasman Oct 19, 2017

Collaborator

package-lock.json shouldn't be deleted completely - it should be reverted to its original version. I'd suggest running git rebase -i master, deleting the lines for the first two commits (ce0f69b and
8dec2f4), and then re-pushing with the --force option.

Collaborator

gasman commented Oct 19, 2017

package-lock.json shouldn't be deleted completely - it should be reverted to its original version. I'd suggest running git rebase -i master, deleting the lines for the first two commits (ce0f69b and
8dec2f4), and then re-pushing with the --force option.

@heymonkeyriot

This comment has been minimized.

Show comment
Hide comment
@heymonkeyriot

heymonkeyriot Oct 19, 2017

Contributor

Thanks @gasman. Apologies for the confusion with it. Will sort out getting the package-lock.json file corrected and back here tomorrow morning.

Contributor

heymonkeyriot commented Oct 19, 2017

Thanks @gasman. Apologies for the confusion with it. Will sort out getting the package-lock.json file corrected and back here tomorrow morning.

@heymonkeyriot

This comment has been minimized.

Show comment
Hide comment
@heymonkeyriot

heymonkeyriot Dec 10, 2017

Contributor

Good spot. In the longterm I think that's probably the direction we should take where all user input uses Roboto Slab, whilst all the Wagtail UI is OpenSans. But agree - with what I think you're saying - that that's out of scope of these changes.

Contributor

heymonkeyriot commented Dec 10, 2017

Good spot. In the longterm I think that's probably the direction we should take where all user input uses Roboto Slab, whilst all the Wagtail UI is OpenSans. But agree - with what I think you're saying - that that's out of scope of these changes.

@gasman gasman added this to Planned for 2.0 in Roadmap Jan 3, 2018

@BertrandBordage

This comment has been minimized.

Show comment
Hide comment
@BertrandBordage

BertrandBordage Jan 8, 2018

Member

Can we help on this in any way? Seems like this is one of our main blockers for 2.0 now.

Member

BertrandBordage commented Jan 8, 2018

Can we help on this in any way? Seems like this is one of our main blockers for 2.0 now.

@tomdyson

This comment has been minimized.

Show comment
Hide comment
@tomdyson

tomdyson Jan 10, 2018

Contributor

@heymonkeyriot thanks for your recent work on this (commits on 10 Dec 2017). Do you think this is ready now, or is there more to do?

Contributor

tomdyson commented Jan 10, 2018

@heymonkeyriot thanks for your recent work on this (commits on 10 Dec 2017). Do you think this is ready now, or is there more to do?

@BertrandBordage

This comment has been minimized.

Show comment
Hide comment
@BertrandBordage

BertrandBordage Apr 16, 2018

Member

Closing this PR since the StreamField UI is going to be fully rebuilt by me as part of the Wagtail’s first Kickstarter campaign.
https://www.kickstarter.com/projects/noripyt/wagtails-first-hatch

Member

BertrandBordage commented Apr 16, 2018

Closing this PR since the StreamField UI is going to be fully rebuilt by me as part of the Wagtail’s first Kickstarter campaign.
https://www.kickstarter.com/projects/noripyt/wagtails-first-hatch

@thibaudcolas

This comment has been minimized.

Show comment
Hide comment
@thibaudcolas

thibaudcolas Apr 16, 2018

Member

@BertrandBordage Generally I don't think it's a good idea to close PRs in advance of future work. We of course do not want people to work on solutions to the same problem at the same time, so it's good to give a heads up everywhere, but at this point in time this PR still has a lot of relevance.

I'm not sure how appropriate this rule is in this scenario, but keeping things open "until proven irrelevant" doesn't have much drawbacks. See also #4215, which tackles the same issue as this PR but has been kept open so far.

Member

thibaudcolas commented Apr 16, 2018

@BertrandBordage Generally I don't think it's a good idea to close PRs in advance of future work. We of course do not want people to work on solutions to the same problem at the same time, so it's good to give a heads up everywhere, but at this point in time this PR still has a lot of relevance.

I'm not sure how appropriate this rule is in this scenario, but keeping things open "until proven irrelevant" doesn't have much drawbacks. See also #4215, which tackles the same issue as this PR but has been kept open so far.

@heymonkeyriot

This comment has been minimized.

Show comment
Hide comment
@heymonkeyriot

heymonkeyriot Apr 16, 2018

Contributor

I think it makes sense to close the PR. I'm afraid I won't have time to finish the outstanding reviews on the PR, and the direction that Bertrand's taking makes sense. Good luck with it all!

Contributor

heymonkeyriot commented Apr 16, 2018

I think it makes sense to close the PR. I'm afraid I won't have time to finish the outstanding reviews on the PR, and the direction that Bertrand's taking makes sense. Good luck with it all!

@BertrandBordage

This comment has been minimized.

Show comment
Hide comment
@BertrandBordage

BertrandBordage Apr 17, 2018

Member

Superseded by #4473.

Member

BertrandBordage commented Apr 17, 2018

Superseded by #4473.

@gasman gasman removed this from Planned for 2.1 in Roadmap Apr 18, 2018

@tmsndrs tmsndrs removed this from Design in progress in UI/UX backlog Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment