Join GitHub today
RFC:21 Revision scheduled publishing #4050
The current implementation does not execute on the
There is an indicator in the revisions index for the scheduled revision so it is fairly easy to see where it stands in the revisions stack.
@hakjoon I took a look at this tonight, checked out the PR locally and also read through the code changes, below are some comments/thoughts/screenshots.
This is an awesome feature! Awesome work on this.
1. revisions_unschedule view/method should check for invalid URL
This view should check if there is an actual unschedule action that can occur, otherwise it might make for a confusing user experience in edge cases.
Let's say you happen to open the 'unschedule revision' link (or copy to clipboard), but the revision has already been unpublished when you actually open the URL. There is no indicator that you cannot do this action as it has already been done.
@lb- Thank you for the feedback.
I think this makes sense. I originally thought of adding this but based the view on the unpublish view which did not have a similar check, so ended up leaving it out. My thought was that one would not get to it without having a link from a scheduled revision, but your point about bookmarks, url completion is very valid. Feels like it should be an easy enough change.
I believe this should be easy enough to accommodate.
I wanted to see what the general feeling was without this since we don't currently have it for scheduled pages, but I should probably go into more detail as to what I think the required changes are.
From my digging I think we would have to expose something akin to a
A second accessor would be simple but it does start polluting the API for the page model a bit and changing the existing property does change the public API so I was hesitant to do it without some buy in. The change would allow for a
One other thing that is needed is some additional docs relating to this feature:
Also see #2841 for general older feedback on the docs surrounding scheduled publishing.
I can see that the docs for scheduled publishing are pretty sparse but it would be good to cover a few of these gaps now that this feature will be slightly more complex.
Pushed an initial stab at documentation. Fair warning I'm pretty bad at writing docs.
I also added a more specific message when scheduling a revision for a page that is already live per @lb- suggestion.
Regarding revisions_unschedule view/method should check for invalid URL currently if you try to unschedule a revision that is not scheduled nothing really happens since all it does is clear