Join GitHub today
External link includes selected text #4366
As described in issue #4328 selected text wasn't populated when adding
I am not sure new tests are needed?
left a comment
This seems to be working well! I did some refactorings, still have more testing to do but this looks good code-wise.
This isn't strictly related to this PR but I find this feature quite confusing when adding a link over multiple blocks at once:
I don't see a way to make this work though (single-line field will never fit a multi-line selection). Again, this isn't related to those changes so not worth holding this PR for that.
Mar 20, 2018
A pleasure to get involved :-) Thanks for everything you have done to help @thibaudcolas…
On 20 March 2018 at 22:49, Tom Dyson ***@***.***> wrote: Thanks @tonyyates <https://github.com/tonyyates> and @thibaudcolas <https://github.com/thibaudcolas>! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4366 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAu-V-9fUfIUPyOzx1lAYVpLP1jMmxnGks5tgYd3gaJpZM4SqoBX> .