Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Upgrade Draftail to v1.2.1. Fix #4985, adds more Markdown shortcuts #5117
Here is the combined CHANGELOG for what's relevant to Wagtail:
Out of all of these the ones that aren't complete fringe cases are #4985, and "fix entity removal when selection is backwards".
None of those API additions will be usable within Wagtail (at least without hacks) until corresponding rich text features APIs are built to allow their configuration. The last 2 additions would already be usable but they would only be useful when leveraging the other APIs.
Ok, the regression with bold/italic/code/underline being always available as keyboard shortcuts should be fixed, and I finished testing on mobile devices. @jonnyscholes @xfxf please go ahead if you can have a look at this and test it a bit.
Beyond the usual manual smoke testing, the interesting bits to test would be:
Mar 15, 2019
referenced this pull request
Mar 15, 2019
Tested the above in Chrome on MacOS. All 3 of the referenced issues seem to be resolved/completed. One note about bold/italic shortcuts is they only worked for me if I didnt end my text in a space. eg
For the Markdown, yes, this is done on purpose. I tried to find a balance between too eagerly matching patterns that people didn't mean to be Markdown, and not matching things that are valid Markdown but could also be something else. The end result is inspired by Dropbox Paper, which has a similar behavior for whitespace.
This is applied to text from the beginning of the block that has focus, to where the cursor is, including the character that's typed when triggering the matching.
If anyone wants to test this matching, https://demo.draftail.org/storybook/?path=/story/draftail--simple is a good place.