Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django models import to Site Settings docs #5278

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
2 participants
@davidjb
Copy link
Contributor

commented May 3, 2019

Makes the implied import of Django's models explicit within the Site Settings documentation. This helps clarify where the fields are coming from (eg that they're not Wagtail-specific).

This doesn't seem overly "significant" (as per https://docs.wagtail.io/en/latest/contributing/committing.html#update-changelog-txt-and-release-notes) but let me know if you'd like me to update the changelog/etc.


Before submitting, please review the contributor guidelines http://docs.wagtail.io/en/latest/contributing/index.html and check the following:

  • Do the tests still pass? (http://docs.wagtail.io/en/latest/contributing/developing.html#testing) N/A
  • Does the code comply with the style guide? (Run make lint from the Wagtail root) N/A
  • For Python changes: Have you added tests to cover the new/fixed behaviour? N/A
  • For front-end changes: Did you test on all of Wagtail’s supported browsers? N/A.
  • For new features: Has the documentation been updated accordingly? N/A
@squash-labs

This comment has been minimized.

Copy link

commented May 3, 2019

Manage this branch in Squash

Test this branch here: https://davidjbpatch-2-xj88f.squash.io

@gasman gasman merged commit 602cd50 into wagtail:master May 3, 2019

3 checks passed

ci/circleci: backend Your tests passed on CircleCI!
Details
ci/circleci: frontend Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gasman

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

Thanks @davidjb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.