Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement RealisticCamera #70
Comments
wahn
self-assigned this
Nov 21, 2018
wahn
added
the
enhancement
label
Nov 21, 2018
This comment has been minimized.
This comment has been minimized.
|
Matt Pharr answered to the mailing list:
|
This comment has been minimized.
This comment has been minimized.
|
Before starting to work on diff --git a/maya/renderData/pbrt_feature_demo_camera_realistic.pbrt b/maya/renderData/pbrt_feature_demo_camera_realistic.pbrt
index 8c22db6..b0b8ac1 100644
--- a/maya/renderData/pbrt_feature_demo_camera_realistic.pbrt
+++ b/maya/renderData/pbrt_feature_demo_camera_realistic.pbrt
@@ -26,11 +26,12 @@ Accelerator "bvh"
# Camera begin
Scale -1 1 1
LookAt 0.000000 4.250000 -45.000000 -0.000000 -0.177129 -2.878684 -0.000000 0.994522 0.104528
-Camera "realistic"
- "float aperturediameter" [1.0]
- "float focusdistance" [10.0]
- "bool simpleweighting" ["true"]
- "string lensfile" ["../assets/pbrt-v3-scenes/lenses/dgauss.50mm.dat"]
+Camera "perspective"
+# Camera "realistic"
+# "float aperturediameter" [1.0]
+# "float focusdistance" [10.0]
+# "bool simpleweighting" ["true"]
+# "string lensfile" ["../assets/pbrt-v3-scenes/lenses/dgauss.50mm.dat"]
# Camera end
WorldBegin |
added a commit
that referenced
this issue
Dec 3, 2018
This comment has been minimized.
This comment has been minimized.
|
BTW the lens data file used in the example ( # D-GAUSS F/2 22deg HFOV
# US patent 2,673,491 Tronnier"
# Moden Lens Design, p.312"
# Scaled to 50 mm from 100 mm
# radius axpos N aperture
29.475 3.76 1.67 25.2
84.83 0.12 1 25.2
19.275 4.025 1.67 23
40.77 3.275 1.699 23
12.75 5.705 1 18
0 4.5 0 17.1
-14.495 1.18 1.603 17
40.77 6.065 1.658 20
-20.385 0.19 1 20
437.065 3.22 1.717 20
-39.73 0 1 20 |
This comment has been minimized.
This comment has been minimized.
|
Chapter in the online book: http://www.pbr-book.org/3ed-2018/Camera_Models/Realistic_Cameras.html |
referenced
this issue
Dec 5, 2018
referenced
this issue
Dec 5, 2018
referenced
this issue
Dec 6, 2018
referenced
this issue
Dec 6, 2018
referenced
this issue
Dec 6, 2018
referenced
this issue
Dec 7, 2018
referenced
this issue
Dec 10, 2018
referenced
this issue
Dec 10, 2018
This comment has been minimized.
This comment has been minimized.
|
Since commit cbb1d2d the Rust version seems to render fine using the |
wahn
closed this
Dec 11, 2018
This comment has been minimized.
This comment has been minimized.
|
BTW they rings visible in the C++ version are fixed now: |
referenced
this issue
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment


wahn commentedNov 21, 2018
I asked on the PBRT mailing list (pbrt@googlegroups.com):
Are there any example .pbrt files for EnvironmentCamera and/or RealisticCamera? I couldn't find any example scenes using them ...And Haarm-Pieter Duiker replied with:
https://github.com/hpd/PBRTForMaya/tree/master/maya/renderDataFinding the one example for the
RealisticCamera:And the resulting image (rendered with the C++ version of PBRT):
Now, lets add the Rust code to render the same image ...