Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Improve multi platform builds #1373

Merged

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented May 3, 2022

  • Make sure to reset the default Arch of the build options and not keep the previous one.
  • Expand to the full platform in outputBinaries so e.g. -platform windows can be used with -nsis

- Make sure to reset the default Arch of the build options and not keep the previous one.
- Expand to the full platform in outputBinaries so e.g. `-platform windows` can be used with `-nsis`
@leaanthony leaanthony merged commit 2d66d21 into wailsapp:master May 3, 2022
@leaanthony
Copy link
Member

If the path of the output binaries has changed, do you think we need to update the docs?

@stffabi stffabi deleted the feature/improve-multiplatform-builds branch May 4, 2022 05:42
@stffabi
Copy link
Collaborator Author

stffabi commented May 4, 2022

Thanks for merging.

The PR should not affect the path of the output binaries. The full platform expansion is only used as key of the map from platform to the output path. This map is only used for NSIS to find the binaries.

But maybe I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants