[v2] Improve multi platform builds#1373
Merged
leaanthony merged 1 commit intowailsapp:masterfrom May 3, 2022
Merged
Conversation
- Make sure to reset the default Arch of the build options and not keep the previous one. - Expand to the full platform in outputBinaries so e.g. `-platform windows` can be used with `-nsis`
Member
|
If the path of the output binaries has changed, do you think we need to update the docs? |
Collaborator
Author
|
Thanks for merging. The PR should not affect the path of the output binaries. The full platform expansion is only used as key of the map from platform to the output path. This map is only used for NSIS to find the binaries. But maybe I'm missing something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-platform windowscan be used with-nsis