Skip to content

[v2] During wails dev only use reload logic if no AssetsHandler are in use #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2022
Merged

[v2] During wails dev only use reload logic if no AssetsHandler are in use #1385

merged 1 commit into from
May 6, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented May 5, 2022

This slows down every GET request to the AssetsHandler taking 5s

Proposal to fix #1380

@stffabi
[v2] During wails dev only use reload logic if no AssetsHandler are i…
b72c651 
…n use

This slows down every GET request to the AssetsHandler taking 5s
@stffabi stffabi mentioned this pull request May 5, 2022
Closed
@leaanthony leaanthony marked this pull request as ready for review May 5, 2022 20:40
@leaanthony leaanthony enabled auto-merge (squash) May 5, 2022 20:40
@leaanthony leaanthony merged commit 5f61230 into wailsapp:master May 6, 2022
@stffabi stffabi deleted the feature/wails-dev-disable-retry-assetshandler branch May 7, 2022 22:41
@stffabi
Copy link
Collaborator Author

stffabi commented May 7, 2022

Thanks for merging 👍

@leaanthony
Copy link
Member

Looks like self approval isn't a thing :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaanthony leaanthony leaanthony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset Handler takes a long time to hand-off to custom asset handler in dev mode
2 participants
@stffabi @leaanthony