Skip to content

[v2, linux] Make sure to execute the menu callbacks on a new goroutine#1403

Merged
stffabi merged 2 commits intowailsapp:masterfrom
stffabi:feature/linux-menu-callback-new-thread
May 17, 2022
Merged

[v2, linux] Make sure to execute the menu callbacks on a new goroutine#1403
stffabi merged 2 commits intowailsapp:masterfrom
stffabi:feature/linux-menu-callback-new-thread

Conversation

@stffabi
Copy link
Copy Markdown
Collaborator

@stffabi stffabi commented May 17, 2022

Fixes #1402

@stffabi stffabi marked this pull request as ready for review May 17, 2022 08:05
@stffabi stffabi enabled auto-merge (squash) May 17, 2022 08:06
@stffabi stffabi changed the title [v2, linux] Make sure to excute the menu callbacks on a new goroutine [v2, linux] Make sure to execute the menu callbacks on a new goroutine May 17, 2022
@stffabi stffabi disabled auto-merge May 17, 2022 08:08
@stffabi stffabi enabled auto-merge (squash) May 17, 2022 08:08
Copy link
Copy Markdown
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Really nice job 👍

@stffabi stffabi merged commit c97e1c5 into wailsapp:master May 17, 2022
@stffabi stffabi deleted the feature/linux-menu-callback-new-thread branch May 17, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2] runtime.SomeDialog causes application to crash on linux

2 participants