Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature - add race detector to build & dev #1426

Merged
merged 2 commits into from
May 28, 2022

Conversation

lyimmi
Copy link
Contributor

@lyimmi lyimmi commented May 26, 2022

This pull request resolves #1425 feature request, by adding the -race flag to wails build and wails dev commands.

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Would it be possible to add the flag to the docs in the website docs here?

https://github.com/wailsapp/wails/blob/master/website/docs/reference/cli.mdx

@lyimmi
Copy link
Contributor Author

lyimmi commented May 27, 2022

Pushed in the changes for the docs.

@lyimmi lyimmi requested a review from leaanthony May 27, 2022 05:19
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@leaanthony leaanthony merged commit f6425a6 into wailsapp:master May 28, 2022
@lyimmi lyimmi deleted the feature/race-detector branch May 28, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2] Add race detector to dev & build commands
2 participants