-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create gitignore when using g option #1430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this. Ioutil is deprecated but there's an equivalent method in the Io package. Otherwise LGTM
Please also make sure to use |
@stffabi I may be reading it wrong but it looks like forward slash is the format used for all platforms? https://git-scm.com/docs/gitignore This seems to be backed up by the Microsoft documentation at https://docs.microsoft.com/en-us/azure/devops/repos/git/ignore-files?view=azure-devops&viewFallbackFrom=vsts&tabs=visual-studio-2019#use-gitignore-to-prevent-tracking-of-files
|
Yeah, the comment was about the os.WriteFile argument and not for the content in .gitignore. |
@jaesung9507 Sorry for not being clear enough in my comment and for wasting your time with those filepath.Join in the .gitignore content. |
Ah all good 😃 I should have thought of that 😉 |
Head branch was pushed to by a user without write access
Thank you for your kind code review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this PR 👍
No description provided.