Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create gitignore when using g option #1430

Merged
merged 3 commits into from
May 31, 2022
Merged

Conversation

jaesung9507
Copy link
Contributor

No description provided.

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this. Ioutil is deprecated but there's an equivalent method in the Io package. Otherwise LGTM

@stffabi
Copy link
Collaborator

stffabi commented May 30, 2022

Please also make sure to use filepath.Join to join the path, otherwise it might fail on Windows.

@leaanthony leaanthony enabled auto-merge (squash) May 30, 2022 13:23
@leaanthony
Copy link
Member

leaanthony commented May 30, 2022

@stffabi I may be reading it wrong but it looks like forward slash is the format used for all platforms? https://git-scm.com/docs/gitignore

This seems to be backed up by the Microsoft documentation at https://docs.microsoft.com/en-us/azure/devops/repos/git/ignore-files?view=azure-devops&viewFallbackFrom=vsts&tabs=visual-studio-2019#use-gitignore-to-prevent-tracking-of-files

Windows users must use a forward slash path separator in a .gitignore file instead of a backslash. All users must add a trailing / when specifying a folder.

@stffabi
Copy link
Collaborator

stffabi commented May 30, 2022

Yeah, the comment was about the os.WriteFile argument and not for the content in .gitignore.
Sorry I wasn't clear enough about that in my comment. 😔

@stffabi
Copy link
Collaborator

stffabi commented May 30, 2022

@jaesung9507 Sorry for not being clear enough in my comment and for wasting your time with those filepath.Join in the .gitignore content.

@leaanthony
Copy link
Member

Ah all good 😃 I should have thought of that 😉

auto-merge was automatically disabled May 31, 2022 00:28

Head branch was pushed to by a user without write access

@jaesung9507
Copy link
Contributor Author

@leaanthony @stffabi

Thank you for your kind code review.

Copy link
Collaborator

@stffabi stffabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this PR 👍

@stffabi stffabi enabled auto-merge (squash) May 31, 2022 05:11
@stffabi stffabi disabled auto-merge May 31, 2022 05:11
@stffabi stffabi enabled auto-merge (squash) May 31, 2022 05:12
@stffabi stffabi merged commit f292e22 into wailsapp:master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants