-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feature: add runtime func WindowSetAlwaysOnTop #1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add runtime func WindowSetAlwaysOnTop #1442
Conversation
leaanthony
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this. A few things:
- there's already functions for top level windows that we call during startup so we should reuse those
- It looks like the calls to set and unset the top window are the same
- We'd need to add a JavaScript method for completeness
- The docs will need updating with the new runtime method
It's a good start though! 👍
Because sometimes we need to dynamic set top/untop , so startup option is not enough. Fix set and unset the top window are the same , i add WindowSetUnalwaysOnTop func. |
8045a7b to
0ec7a24
Compare
add a JavaScript method for completeness |
|
This is looking good! Do you think we should refactor it so that we have a single API call |
|
Yes, i think a single api call WindowSetAlwaysOnTop(bool) is a good idea. |
|
LGTM! |
This PR resolves feature request #1439.
Add windows 、linux platform WindowSetAlwaysOnTop function .
Darwin platform no environment , Not implemented.
JS runtime interface Not implemented.