Improve theme change at runtime #1473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
6abda7b
|
| Status: | ⚡️ Build in progress... |
stffabi
reviewed
Jun 21, 2022
Collaborator
stffabi
left a comment
stffabi
left a comment
There was a problem hiding this comment.
Nice work, that definitely improve the theme changing 🚀 .
I just added some comments about possibly loosing the adaption to system changes, like active/inactive and changing the system theme.
|
|
||
| // Custom theme | ||
| if win32.SupportsCustomThemes() && customTheme != nil { | ||
| if w.isActive { |
Collaborator
There was a problem hiding this comment.
Don't we need to also set w.themeChanged = true when w.isActive gets changed during w32.WM_ACTIVATE?
I think we might loose the adaption of the active/inactive color when customThemes are active.
# Conflicts: # v2/internal/frontend/desktop/windows/window.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes runtime theme changes