Better signal handling#1488
Merged
Merged
Conversation
Deploying with
|
| Latest commit: |
c221bc9
|
| Status: | ⚡️ Build in progress... |
stffabi
approved these changes
Jun 24, 2022
stffabi
left a comment
stffabi
left a comment
Contributor
There was a problem hiding this comment.
Nice improvement 👍. LGTM, just a minor comment if we need the waitgroup.
| gosignal.Notify(signalChannel, os.Interrupt, syscall.SIGTERM, syscall.SIGINT) | ||
|
|
||
| m.wg.Add(1) | ||
| var wg sync.WaitGroup |
Contributor
There was a problem hiding this comment.
It seems like we are not calling wg.Wait() anywhere. Are we maybe missing that or could we just remove the waitgroup completely?
Member
Author
There was a problem hiding this comment.
Looks like it was left in after the simplification. I'll remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed
ctrl-cisn't handled and leads to ungraceful shutdown.