Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Improvements to the dev command #1510

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Jun 30, 2022

  • Make sure to kill the debug process in all cases even if an error occurred
  • Make sure to kill the last started binary process
  • Improve starting of dev watcher command

…tart and the user stopped wails dev with ctrl-c
Wails dev now also fails if the dev watcher could not be started. Since
the dev watcher is used to start e.g. vite to serve the frontend, it does
not make much sense to let Wails dev be running if the dev
watcher failed to start.
- Make sure to kill the debug process in all cases even if an error occured.
- Make sure to kill the last started binary process
@stffabi stffabi requested a review from leaanthony June 30, 2022 08:47
@leaanthony leaanthony merged commit 41d1bf3 into wailsapp:master Jun 30, 2022
@stffabi stffabi deleted the feature/dev-improvements branch July 25, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants