[v2] Improvements to the dev command - #1510
Merged
Merged
Conversation
stffabi
commented
Jun 30, 2022
stffabi
commented
Contributor
- Make sure to kill the debug process in all cases even if an error occurred
- Make sure to kill the last started binary process
- Improve starting of dev watcher command
…tart and the user stopped wails dev with ctrl-c
Wails dev now also fails if the dev watcher could not be started. Since the dev watcher is used to start e.g. vite to serve the frontend, it does not make much sense to let Wails dev be running if the dev watcher failed to start.
- Make sure to kill the debug process in all cases even if an error occured. - Make sure to kill the last started binary process
leaanthony
approved these changes
Jun 30, 2022
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.