Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/auto devserver port #1547

Merged
merged 6 commits into from
Jul 12, 2022
Merged

Feature/auto devserver port #1547

merged 6 commits into from
Jul 12, 2022

Conversation

leaanthony
Copy link
Member

@leaanthony leaanthony commented Jul 11, 2022

This PR adds an "auto" option for frontend:dev:serverUrl that attempts to determine the URL vite is running on via the vite output.
Updated default templates.
Fix package/variable name clashes.

Fixes #1545

@leaanthony leaanthony requested a review from stffabi July 11, 2022 10:42
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 11, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d021d09
Status: ✅  Deploy successful!
Preview URL: https://705a8c68.wails-website.pages.dev
Branch Preview URL: https://feature-auto-devserver-port.wails-website.pages.dev

View logs

Copy link
Collaborator

@stffabi stffabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great enhancement for the frontend server integration 🚀

I've left some comments about the stdout handling, which probably might need to be addressed.

v2/cmd/wails/internal/commands/dev/dev.go Outdated Show resolved Hide resolved
v2/cmd/wails/internal/commands/dev/dev.go Outdated Show resolved Hide resolved
v2/cmd/wails/internal/commands/dev/dev.go Outdated Show resolved Hide resolved
v2/cmd/wails/internal/commands/dev/dev.go Outdated Show resolved Hide resolved
v2/cmd/wails/internal/commands/dev/dev.go Outdated Show resolved Hide resolved
@leaanthony
Copy link
Member Author

Pushed a new approach which I feel is a lot better. LMKWYT!

@leaanthony leaanthony requested a review from stffabi July 12, 2022 10:30
Copy link
Collaborator

@stffabi stffabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Vite port change
2 participants