Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scaling when setting min/max window #1557

Merged
merged 6 commits into from
Jul 23, 2022
Merged

Conversation

leaanthony
Copy link
Member

@leaanthony leaanthony commented Jul 13, 2022

Scaling is only considered when setting the window to fullscreen. This PR considers the scale when setting min/max width/height.

Potential fix for #1517.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 13, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 07e60f3
Status: ✅  Deploy successful!
Preview URL: https://83551c16.wails-website.pages.dev
Branch Preview URL: https://bugfix-linux-scaling-issues.wails-website.pages.dev

View logs

@acheong08
Copy link
Contributor

This seems to be stable, when will it be merged?

@leaanthony
Copy link
Member Author

Waiting for @skamensky to confirm about appoptions Fullscreen: #1517 (comment)

@leaanthony
Copy link
Member Author

@skamensky happy for this to be merged?

@leaanthony leaanthony marked this pull request as ready for review July 21, 2022 10:55
@skamensky
Copy link
Contributor

From my I've seen it's a partial fix without any regressesions. I'll check layer today to see if there's something I can do to make it a complete fix. But if not, I see no reason not to merge it.

@leaanthony
Copy link
Member Author

It was a full fix on my system. Startup options worked as expected

@leaanthony leaanthony merged commit ae756a8 into master Jul 23, 2022
@leaanthony leaanthony deleted the bugfix/linux_scaling_issues branch July 23, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants