Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-build hooks. Print command output when verbosity flag set. #1578

Merged
merged 2 commits into from
Jul 17, 2022

Conversation

leaanthony
Copy link
Member

Adds a "preBuildHooks" option which runs before any builds. Supports different platforms & architectures.
Fixes #1577

@leaanthony leaanthony requested a review from stffabi July 16, 2022 23:23
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 16, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b56f84b
Status: ✅  Deploy successful!
Preview URL: https://50c27dbe.wails-website.pages.dev
Branch Preview URL: https://feature-pre-build-hooks.wails-website.pages.dev

View logs

Copy link

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% what I was hoping for. Granted, my golang code-review skills are subpar, so I didn't dive into your implementation details, but the interface is absolutely what I would hope for as an end-user building an app with wails!

@leaanthony
Copy link
Member Author

leaanthony commented Jul 17, 2022

Effort that goes into issues = effort that goes into PRs 👍 Thanks so much for the detailed request. Let's get that too many open files issue fixed 👍

@leaanthony
Copy link
Member Author

Did a little refactor to remove duplication.

Copy link
Collaborator

@stffabi stffabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leaanthony leaanthony merged commit f46e825 into master Jul 17, 2022
@leaanthony leaanthony deleted the feature/pre-build-hooks branch July 17, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pre-build hook with wails dev & wails build
3 participants