Add pre-build hooks. Print command output when verbosity flag set. #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
b56f84b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://50c27dbe.wails-website.pages.dev |
| Branch Preview URL: | https://feature-pre-build-hooks.wails-website.pages.dev |
SgtPooki
approved these changes
Jul 17, 2022
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
100% what I was hoping for. Granted, my golang code-review skills are subpar, so I didn't dive into your implementation details, but the interface is absolutely what I would hope for as an end-user building an app with wails!
Member
Author
|
Effort that goes into issues = effort that goes into PRs 👍 Thanks so much for the detailed request. Let's get that too many open files issue fixed 👍 |
Member
Author
|
Did a little refactor to remove duplication. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a "preBuildHooks" option which runs before any builds. Supports different platforms & architectures.
Fixes #1577