Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override platform with GOOS and GOARCH #1618

Merged
merged 8 commits into from
Jul 21, 2022
Merged

Override platform with GOOS and GOARCH #1618

merged 8 commits into from
Jul 21, 2022

Conversation

leaanthony
Copy link
Member

Whilst -platform worked as expected, the GOOS and GOARCH flags were not overriding the platform.
Fix for #1610

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 20, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0303425
Status:⚡️  Build in progress...

View logs

stffabi
stffabi requested changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@stffabi stffabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we loose the ability to do multi platform builds in a correct way.

Should we either allow setting the GOOS/GOARCH env vars or the platform string, but not both?

v2/cmd/wails/internal/commands/build/build.go Outdated Show resolved Hide resolved
v2/cmd/wails/internal/commands/build/build.go Outdated Show resolved Hide resolved
@leaanthony leaanthony requested a review from stffabi July 21, 2022 10:52
stffabi
stffabi approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@stffabi stffabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@leaanthony
Copy link
Member Author

Thanks heaps for reviewing. Great catches! 🔥

@leaanthony leaanthony merged commit 5a3d45b into master Jul 21, 2022
@leaanthony leaanthony deleted the bugfix/env-var-override branch July 21, 2022 11:25
@waltzofpearls waltzofpearls mentioned this pull request Aug 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stffabi stffabi stffabi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leaanthony @stffabi