Skip to content

[v2, darwin] Use kern.osversion for os id in doctor #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Jul 28, 2022

It seems like kern.osrevision is always 199506 since several years
and kern.osversion maps to the official documented build id.

Example: MacOS 12.5 with ID 21G72

It seems like kern.osrevision is always 199506 since several years
and kern.osversion maps to the official documented build id.

Example: MacOS 12.5 with ID 21G72
@stffabi stffabi requested a review from leaanthony July 28, 2022 14:50
@stffabi stffabi enabled auto-merge (squash) July 28, 2022 14:50
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stffabi stffabi merged commit de36477 into wailsapp:master Jul 28, 2022
@stffabi stffabi deleted the bugfix/darwin-os-id branch August 3, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants