Skip to content

Remove duplicate defs in win32/window.go #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlbinoDrought
Copy link
Contributor

Introduced in 70c484f

Until these duplicate defs are removed, bleeding edge Windows build fail with:

  Build command: go build -trimpath -tags desktop,production -ldflags -w -s -H windowsgui -o /app/build/bin/app.exe
  Environment: HOSTNAME=e7e5205f866a PATH=/go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin GOPATH=/go PWD=/app GOLANG_VERSION=1.19 GOOS=windows GOARCH=amd64
go list error: exit status 2: # github.com/wailsapp/wails/v2/internal/frontend/desktop/windows/win32
wails/v2/internal/frontend/desktop/windows/win32/window.go:18:2: WS_MINIMIZE redeclared in this block
	wails/v2/internal/frontend/desktop/windows/win32/window.go:16:2: other declaration of WS_MINIMIZE
wails/v2/internal/frontend/desktop/windows/win32/window.go:146:6: IsWindowMinimised redeclared in this block
	wails/v2/internal/frontend/desktop/windows/win32/window.go:120:6: other declaration of IsWindowMinimised

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Bad merge 😱

@leaanthony leaanthony merged commit 85b8c30 into wailsapp:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants