Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add check for minimum required go version #1853

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Sep 14, 2022

  • Update out of sync go.mod with minimum go version
  • Check for minimum go version during build with build constraint
    “internal/goversion/build_constraint.go:9:2: MinGoVersionRequired (constant "You need Go 1.18 or newer to compile this program" of type string) is not used”

@stffabi stffabi added this to the v2.1.0 milestone Sep 14, 2022
@leaanthony
Copy link
Member

Thanks for this! For the v2 release, the minimum version will be 1.18. I think moving forward, we'll always support current-1 as a minimum. Thoughts?

@stffabi
Copy link
Collaborator Author

stffabi commented Sep 14, 2022

According to docs, we currently require 1.17 as minimum version that's why I used 1.17 as minimum version. If we require 1.18 we should update the docs for the v2 release.

I think moving forward, we'll always support current-1 as a minimum. Thoughts?

Yeah, I also think that's fine, it corresponds to the Go Release Policy: Each major Go release is supported until there are two newer major releases.

@leaanthony
Copy link
Member

The docs and templates will be updated 👍

@stffabi
Copy link
Collaborator Author

stffabi commented Sep 14, 2022

The docs and templates will be updated 👍

I've just pushed PR #1854 for that.

- Update out of sync go.mod with minimum go version
- Check for minimum go version during build with build constraint
  “internal/goversion/build_constraint.go:9:2: MinGoVersionRequired (constant "You need Go 1.18 or newer to compile this program" of type string) is not used”
@leaanthony
Copy link
Member

LGTM!

@leaanthony leaanthony merged commit f1dc9eb into wailsapp:master Sep 14, 2022
@stffabi stffabi deleted the feature/min-go-version-check branch September 14, 2022 21:42
@stffabi
Copy link
Collaborator Author

stffabi commented Sep 14, 2022

Thanks for merging, didn't expect this to still land in v2. 🙏

@leaanthony
Copy link
Member

With the need to use 1.18 I think it's a good addition 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants