[cli] Add check for minimum required go version #1853
Conversation
|
Thanks for this! For the v2 release, the minimum version will be 1.18. I think moving forward, we'll always support current-1 as a minimum. Thoughts? |
|
According to docs, we currently require 1.17 as minimum version that's why I used 1.17 as minimum version. If we require 1.18 we should update the docs for the v2 release.
Yeah, I also think that's fine, it corresponds to the Go Release Policy: |
|
The docs and templates will be updated 👍 |
I've just pushed PR #1854 for that. |
- Update out of sync go.mod with minimum go version - Check for minimum go version during build with build constraint “internal/goversion/build_constraint.go:9:2: MinGoVersionRequired (constant "You need Go 1.18 or newer to compile this program" of type string) is not used”
stffabi
force-pushed
the
feature/min-go-version-check
branch
from
97f2ebf to
f11935d
Compare
|
LGTM! |
|
Thanks for merging, didn't expect this to still land in v2. 🙏 |
|
With the need to use 1.18 I think it's a good addition 👍 |
2 participants
“internal/goversion/build_constraint.go:9:2: MinGoVersionRequired (constant "You need Go 1.18 or newer to compile this program" of type string) is not used”