Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] Do not generate bindings in the dev app itself #1899

Merged
merged 2 commits into from
Sep 25, 2022
Merged

[dev] Do not generate bindings in the dev app itself #1899

merged 2 commits into from
Sep 25, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Sep 25, 2022

Fixes #1885

@stffabi
[dev] Pass skip bindings to the building process
d2cc783
@stffabi
[dev] Do not generate bindings in the dev app itself
9f40d24 
This is done outside during `wails dev` bootstrapping and
fast regeneration seems to sometime cause locking problems
on Windows.
@stffabi stffabi mentioned this pull request Sep 25, 2022
Closed
leaanthony
leaanthony approved these changes Sep 25, 2022
View reviewed changes
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@leaanthony leaanthony merged commit f5549db into wailsapp:master Sep 25, 2022
@stffabi stffabi deleted the bugfix/pass-skipbindings-no-in-app-generation branch September 25, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaanthony leaanthony leaanthony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run wails dev bug
2 participants
@stffabi @leaanthony