Merged
Conversation
…ctor assethandler/assetserver signatures.
stffabi
approved these changes
Sep 29, 2022
Collaborator
stffabi
left a comment
stffabi
left a comment
There was a problem hiding this comment.
LGTM 🚀 , just a minor comment.
Co-authored-by: stffabi <stffabi@users.noreply.github.com>
Co-authored-by: stffabi <stffabi@users.noreply.github.com>
Co-authored-by: stffabi <stffabi@users.noreply.github.com>
Co-authored-by: stffabi <stffabi@users.noreply.github.com>
Member
Author
|
Nice catch! Thanks 👍 |
lyimmi
added a commit
to lyimmi/wails
that referenced
this pull request
Sep 29, 2022
progress: linux framless resize fix missing framless resize Refactor app (wailsapp#1909) * Application refactor * [windows] refactor out main loop. Create new application struct. Refactor assethandler/assetserver signatures. * Refactor darwin app * Refactor app for linux * Update v2/internal/frontend/assetserver/assethandler.go Co-authored-by: stffabi <stffabi@users.noreply.github.com> * Update v2/internal/frontend/assetserver/assethandler.go Co-authored-by: stffabi <stffabi@users.noreply.github.com> * Update v2/internal/frontend/assetserver/assetserver.go Co-authored-by: stffabi <stffabi@users.noreply.github.com> * Update v2/internal/frontend/assetserver/assetserver.go Co-authored-by: stffabi <stffabi@users.noreply.github.com> Co-authored-by: stffabi <stffabi@users.noreply.github.com> Update README.md bugfix/linux framless window drag (wailsapp#1916)
Merged
| BackgroundColour *RGBA | ||
| // RGBA is deprecated. Please use BackgroundColour | ||
| RGBA *RGBA | ||
| BackgroundColour *RGBA |
Contributor
There was a problem hiding this comment.
Should we add this as a breaking change in release notes ?
Apps working fine on 2.0.0 break on 2.1.0
@leaanthony
Member
Author
There was a problem hiding this comment.
Yes, though there was fair warning it was being removed. But ultimately yes, looks like it needs adding. Apologies we missed that and thanks for raising it.
Contributor
There was a problem hiding this comment.
No worries. Getting 2.1 to work with just a 1 line change is amazing.
LGiki
added a commit
to LGiki/wails-template-nextjs
that referenced
this pull request
Nov 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apppackage