Skip to content

bugfix/linux framless window drag #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lyimmi
Copy link
Contributor

@lyimmi lyimmi commented Sep 29, 2022

This PR fixes #1861.

Checks mouse button press on mouse move and if button is not pressed dragging is canceled.

@leaanthony
Copy link
Member

Nice one! Do you know if this impacts non Linux systems?

@lyimmi
Copy link
Contributor Author

lyimmi commented Sep 29, 2022

Sorry, I forgot to mention it, I think its ok on all platforms, but I'll check it on windows and get back to you. (Can't test it on mac)

@lyimmi
Copy link
Contributor Author

lyimmi commented Sep 29, 2022

Ok, It works on windows and linux as well.

@leaanthony
Copy link
Member

Let's go with it! Thanks 🙏

@leaanthony leaanthony merged commit b1e0477 into wailsapp:master Sep 29, 2022
lyimmi added a commit to lyimmi/wails that referenced this pull request Sep 29, 2022
progress: linux framless resize

fix missing framless resize

Refactor app (wailsapp#1909)

* Application refactor

* [windows] refactor out main loop. Create new application struct. Refactor assethandler/assetserver signatures.

* Refactor darwin app

* Refactor app for linux

* Update v2/internal/frontend/assetserver/assethandler.go

Co-authored-by: stffabi <stffabi@users.noreply.github.com>

* Update v2/internal/frontend/assetserver/assethandler.go

Co-authored-by: stffabi <stffabi@users.noreply.github.com>

* Update v2/internal/frontend/assetserver/assetserver.go

Co-authored-by: stffabi <stffabi@users.noreply.github.com>

* Update v2/internal/frontend/assetserver/assetserver.go

Co-authored-by: stffabi <stffabi@users.noreply.github.com>

Co-authored-by: stffabi <stffabi@users.noreply.github.com>

Update README.md

bugfix/linux framless window drag (wailsapp#1916)
@lyimmi lyimmi deleted the bugfix/1861_frameless_draggable_window_linux branch September 29, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frameless + draggable window causes multiple issues on Linux
2 participants