add missing resize for framless window on linux#1918
Merged
leaanthony merged 2 commits intowailsapp:masterfrom Sep 29, 2022
Merged
add missing resize for framless window on linux#1918leaanthony merged 2 commits intowailsapp:masterfrom
leaanthony merged 2 commits intowailsapp:masterfrom
Conversation
Member
|
Thanks for this awesome PR! |
|
@lyimmi Excellent work thank you ! @leaanthony When will this be in a realease version? |
Member
|
The weekend hopefully 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1917.
I tried to follow the style of the windows implementation, but there are some differences:
f.ExecJS("window.wails.flags.enableResize = true;")to theruntime:readyevent.mouseButtonlike the x,y coordinates forgtk_window_begin_resize_dragTested it on linux/amd64 & linux/arm, however I'm not too advanced on GTK/GDK/C so a cgo wizard should take a good look at it. :)