Skip to content

add missing resize for framless window on linux#1918

Merged
leaanthony merged 2 commits intowailsapp:masterfrom
lyimmi:bugfix/1917_linux_cannot_resize_frameless_window
Sep 29, 2022
Merged

add missing resize for framless window on linux#1918
leaanthony merged 2 commits intowailsapp:masterfrom
lyimmi:bugfix/1917_linux_cannot_resize_frameless_window

Conversation

@lyimmi
Copy link
Copy Markdown
Contributor

@lyimmi lyimmi commented Sep 29, 2022

This PR fixes #1917.

I tried to follow the style of the windows implementation, but there are some differences:

  1. There is no throttling of the resize event. (It looks like GTK handles it well.)
  2. Since there is no navigationCompleted() on linux, I wired the first f.ExecJS("window.wails.flags.enableResize = true;") to the runtime:ready event.
  3. Created a new global variable mouseButton like the x,y coordinates for gtk_window_begin_resize_drag

Tested it on linux/amd64 & linux/arm, however I'm not too advanced on GTK/GDK/C so a cgo wizard should take a good look at it. :)

@lyimmi lyimmi marked this pull request as draft September 29, 2022 17:22
@lyimmi lyimmi marked this pull request as ready for review September 29, 2022 17:23
@leaanthony leaanthony merged commit 13532e0 into wailsapp:master Sep 29, 2022
@leaanthony
Copy link
Copy Markdown
Member

Thanks for this awesome PR!

@lyimmi lyimmi deleted the bugfix/1917_linux_cannot_resize_frameless_window branch September 29, 2022 23:06
@lic-8
Copy link
Copy Markdown

lic-8 commented Oct 4, 2022

@lyimmi Excellent work thank you !

@leaanthony When will this be in a realease version?

@leaanthony
Copy link
Copy Markdown
Member

The weekend hopefully 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2 Linux] Cannot resize frameless window

3 participants