[webview2loader] Add full featured go implementation by stffabi · Pull Request #1974 · wailsapp/wails

stffabi · 2022-10-14T07:55:48Z

The new go loader can be activated with the exp_gowebview2loader build tag.

leaanthony · 2022-10-15T00:07:57Z

This is incredible! Might take a while for me to get through it but I'll aim to do that this weekend!

leaanthony · 2022-10-16T06:32:10Z

+}
+
+func (r *environmentCreatedHandler) EnvironmentCompleted(errorCode HRESULT, createdEnvironment *ICoreWebView2Environment) HRESULT {
+	// The OpenWebview2Loader has some retry logic and retries once, didn't encounter any case when this would have been


Perhaps @jchv has more insight

Unfortunately, I do not. I also never noticed a case where it is needed. If there is a good reason for it, one would probably have to peel back more layers to find it.

Thanks for your reply. So I think we could leave this as it is for now and see what the feedback will be from the users.

Thanks for taking the time to leave a comment @jchv - appreciate it 🙏

leaanthony · 2022-10-16T06:34:56Z

+)
+
+// Resolve the GoInterface of the specified ComInterfacePointer
+func Resolve[T IUnknown](ifceP uintptr) T {


Love this approach 🚀

stffabi · 2022-10-16T10:13:51Z

This is incredible! Might take a while for me to get through it but I'll aim to do that this weekend!

Thanks so much, was a great experience with all the com specific stuff 😀

leaanthony · 2022-10-16T10:31:25Z

Never thought I'd ever see "com" and "great experience" in the same sentence 😂 Awesome stuff 👍

stffabi · 2022-10-16T11:40:59Z

Never thought I'd ever see "com" and "great experience" in the same sentence 😂 Awesome stuff 👍

That was more meant from a technical point of view of interacting with com and playing nicely together with the go runtime 😀

leaanthony

Looking really good! I've left a couple of very minor questions that are no biggies.

What do you think we need to have in the documentation for people to try it out and get feedback? Is this a flag you'd pass with the -flags parameter for wails build?

I noticed the comment on supporting all the features so we could do away with the dll. What scenarios would we still need it?

stffabi · 2022-10-18T10:11:26Z

Looking really good! I've left a couple of very minor questions that are no biggies.

Thanks for reviewing it ❤️

What do you think we need to have in the documentation for people to try it out and get feedback? Is this a flag you'd pass with the -flags parameter for wails build?

It's a build tag to be passed as -tags: wails build --tags exp_gowebview2loader. As for documentation I hadn't a good idea where to put it, do you have a good idea?

I noticed the comment on supporting all the features so we could do away with the dll. What scenarios would we still need it?

The following features are not supported and I think we explicitly don't want or need them:

Registry Overrides of Parameters: I don't think we want that someone (enduser) can just override the WebView2 options to be used by changing the registry key which maps to the binary. This would e.g. also allow to active the debugger of the webview.
Env Variable Overrides of Parameters: Same as above, from a security perspective I think even more dangerous. This would also allow to active the debugger by just starting the binary with a env variable. We already disable this for the native loader as well.
Does not incorporate GetCurrentPackageInfo to search for an installed runtime: This would allow override the runtime to be when bundled in an appx. So I think not relevant for Wails.

I think the options to be used should always be set by the Wails application and not by some user, which would allow to inspect internals of the app or change the behaviour of it.

leaanthony · 2022-10-18T11:25:13Z

I think we could add these details to the output of wails build to invite people to trial it?

stffabi · 2022-10-18T11:37:22Z

Oh, yeah, that's a great idea. Will add that...

stffabi · 2022-10-18T11:51:20Z

Just added the information to wails build, what do you think about that?

leaanthony · 2022-10-19T09:41:32Z

Yeah, that's great. I'm wondering if we should open a ticket/discussion for capturing the feedback and have that link at the bottom of the CLI output. The issue/discussion should have a bit of detail there: What is the benefit of using it, gotchas, maybe a test matrix so people can report it works with wails doctor output. Thoughts?

stffabi · 2022-10-19T09:47:02Z

Yeah, that sounds great.

The new go loader can be activated with the exp_gowebview2loader build tag.

stffabi · 2022-10-21T07:40:04Z

@leaanthony just added the link to the Feedback - Issue. For the content of the issue we could discuss that in slack.

So I think we are good to go with this one, what do you think?

stffabi · 2022-10-21T14:38:01Z

Awesome, thanks for merging.

stffabi requested a review from leaanthony October 14, 2022 07:55

leaanthony reviewed Oct 16, 2022

View reviewed changes

stffabi commented Oct 16, 2022

View reviewed changes

Comment thread v2/internal/frontend/desktop/windows/go-webview2/pkg/combridge/bridge.go Outdated

stffabi force-pushed the feature/go-webview2loader branch from 3ae5045 to ddb7726 Compare October 16, 2022 12:23

leaanthony approved these changes Oct 18, 2022

View reviewed changes

Comment thread v2/internal/frontend/desktop/windows/go-webview2/pkg/combridge/bridge.go Outdated

Comment thread v2/internal/frontend/desktop/windows/go-webview2/pkg/combridge/bridge.go Outdated

Comment thread v2/internal/frontend/desktop/windows/go-webview2/pkg/edge/create_env_native.go

stffabi force-pushed the feature/go-webview2loader branch 2 times, most recently from ccc859b to 599f5a4 Compare October 18, 2022 10:03

stffabi force-pushed the feature/go-webview2loader branch from f5d64bc to a913766 Compare October 19, 2022 09:45

stffabi force-pushed the feature/go-webview2loader branch from a913766 to 9c6c433 Compare October 20, 2022 07:22

stffabi added 2 commits October 21, 2022 09:25

[webview2loader] Add full featured go implementation

8c3fcdd

The new go loader can be activated with the exp_gowebview2loader build tag.

[build] Add information for using the new webvie2loader

ea81396

stffabi force-pushed the feature/go-webview2loader branch from 9c6c433 to ea81396 Compare October 21, 2022 07:25

stffabi mentioned this pull request Oct 21, 2022

[windows] Go Native WebView2Loader - Feedback #2004

Closed

leaanthony merged commit 0a20c8d into wailsapp:master Oct 21, 2022

stffabi deleted the feature/go-webview2loader branch October 21, 2022 14:37

stffabi mentioned this pull request Nov 1, 2022

Disable the Webview2 security policy #1507

Closed

Uh oh!

Conversation

stffabi commented Oct 14, 2022

Uh oh!

leaanthony commented Oct 15, 2022

Uh oh!

leaanthony Oct 16, 2022

Choose a reason for hiding this comment

Uh oh!

jchv Oct 18, 2022

Choose a reason for hiding this comment

Uh oh!

stffabi Oct 18, 2022

Choose a reason for hiding this comment

Uh oh!

leaanthony Oct 19, 2022

Choose a reason for hiding this comment

Uh oh!

leaanthony Oct 16, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stffabi commented Oct 16, 2022

Uh oh!

leaanthony commented Oct 16, 2022

Uh oh!

stffabi commented Oct 16, 2022

Uh oh!

leaanthony left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stffabi commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaanthony commented Oct 18, 2022

Uh oh!

stffabi commented Oct 18, 2022

Uh oh!

stffabi commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leaanthony commented Oct 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stffabi commented Oct 19, 2022

Uh oh!

stffabi commented Oct 21, 2022

Uh oh!

stffabi commented Oct 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stffabi commented Oct 18, 2022 •

edited

Loading

stffabi commented Oct 18, 2022 •

edited

Loading

leaanthony commented Oct 19, 2022 •

edited

Loading