Skip to content

Conversation

@leaanthony
Copy link
Member

@leaanthony leaanthony commented Oct 16, 2022

This PR offers 2 things:

  1. A new staticanalysis package for running static analysis on Wails projects. The first function implemented using it is GetEmbedDetails which will return a list of embed paths for the project at the given path.
  2. wails build has a new initial step using this information for creating missing directories before attempting to generate the bindings

Over time, I'd hope the static analysis package will take over from the current bindings implementation.

Should fix: #1900

@leaanthony leaanthony requested a review from stffabi October 16, 2022 02:37
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ceb6328
Status: ✅  Deploy successful!
Preview URL: https://5bf55b30.wails.pages.dev
Branch Preview URL: https://feature-static-analysis.wails.pages.dev

View logs

@leaanthony
Copy link
Member Author

Just realised I need to push some fixes for dev

@leaanthony
Copy link
Member Author

Updated and ready for review 👍

Copy link
Collaborator

@stffabi stffabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@leaanthony leaanthony merged commit 96fa188 into master Oct 16, 2022
@leaanthony leaanthony deleted the feature/static-analysis branch October 16, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

On v2.0.0 wails dev or build will fail if dist is not yet generated

3 participants