Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debug] Introducing debug options for debug builds to allow opening the inspector on startup #2080

Merged
merged 1 commit into from
Nov 12, 2022
Merged

[debug] Introducing debug options for debug builds to allow opening the inspector on startup #2080

merged 1 commit into from
Nov 12, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Nov 11, 2022 •
edited
Loading

Some known limitations

  • The initial selected tab depends on the platform implementations. (macOS, Windows: Network-Tab, Linux: Sources-Tab)
  • The inspector is always in foreground
  • Network records might be missing for the first load.

Fixes #2059

Tested on:

  • Windows 11 Pro (22621.819)
  • Mac (13.0 - 22A380)
  • Linux (Fedora 35)

@stffabi stffabi requested a review from leaanthony November 11, 2022 22:09
@stffabi stffabi force-pushed the feature/debug-open-webinspector branch from 7149f5d to 194d127 Compare November 11, 2022 22:11
@stffabi stffabi marked this pull request as ready for review November 11, 2022 22:11
@stffabi stffabi mentioned this pull request Nov 11, 2022
Closed
@stffabi stffabi force-pushed the feature/debug-open-webinspector branch from 194d127 to 4bfb549 Compare November 11, 2022 23:08
@leaanthony
Copy link
Member

LGTM! Added a test matrix to the main PR details. Can confirm it works well for Win11 👍

@stffabi
Copy link
Collaborator Author

stffabi commented Nov 12, 2022

Awesome, I've added the OS versions I've successfully tested it.

@stffabi stffabi force-pushed the feature/debug-open-webinspector branch from 9d73616 to 321aa28 Compare November 12, 2022 08:25
@stffabi stffabi enabled auto-merge (squash) November 12, 2022 08:41
leaanthony
leaanthony approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stffabi stffabi merged commit f6e46ac into wailsapp:master Nov 12, 2022
@stffabi stffabi mentioned this pull request Nov 12, 2022
Merged
@stffabi stffabi deleted the feature/debug-open-webinspector branch November 12, 2022 21:03
@mmghv mmghv mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaanthony leaanthony leaanthony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically open DevTools in wails dev mode
2 participants
@stffabi @leaanthony