Repository navigation
Fix multiple nested build/bin folders in dev mode - #2103
Merged
Merged
Conversation
leaanthony
approved these changes
Nov 17, 2022
Contributor
|
LGTM, would it be possible for you to also add your changes to the "unreleased" changelog here |
Contributor
Author
|
Of course, done! |
Member
|
Yeah, that's how we're tracking changes because GitHub's commit message bundle isn't good enough 😀 |
Contributor
Author
|
Not exactly sure when I can test this on Windows as I wanted, my windows machine having some troubles.. : |
Member
|
I tested on Windows 11:
Thanks heaps @OlegGulevskyy 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following discussion in #2100 - this PR removes assignment to path where executable is stored (
/build/bin). This was adding/build/binto the executable name on each save indevmode, which results in/build/bin/build/bin...duplicated nested path.Have tested on MacOS only, can test on Windows 11 a bit later to make sure no regression