Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[assetserver] Add support for serving the index.html file when requesting a directory #2110

Merged

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Nov 19, 2022

Furthermore this PR improves some error messages for the AssetServer Options and adds some additional checks.

Fixes #2109

@mholt
Copy link
Contributor

mholt commented Nov 20, 2022

Ohh, very nice. I'll give this a try!

@stffabi stffabi force-pushed the feature/assetserver-directory-index-files branch from e1579d4 to 90957ff Compare November 23, 2022 22:37
@stffabi
Copy link
Collaborator Author

stffabi commented Nov 24, 2022

@mholt Just wanted to ask if you eventually found time to give this a try?

@mholt
Copy link
Contributor

mholt commented Nov 27, 2022

@stffabi Sorry for the wait! 😓 I haven't been available much with the holiday and such this week. Thanksgiving is a very big day in the US that disrupts nearly the whole week. I'll try to look at this soon. (Don't wait on me though, if you want to merge it in sooner, I don't want to be a blocker.)

@stffabi
Copy link
Collaborator Author

stffabi commented Nov 27, 2022

I’m sorry, I really didn’t want to stress you.
Hope you had a wonderful time with your beloved ones.

@stffabi stffabi force-pushed the feature/assetserver-directory-index-files branch from 90957ff to 05dd0d1 Compare November 27, 2022 20:46
@leaanthony
Copy link
Member

Thanks for doing this - this is great! I'm going to open a new ticket that I'll do after this has been merged to update the default index.html page with better information on why it is being shown and how to fix it 👍

@stffabi stffabi force-pushed the feature/assetserver-directory-index-files branch from 05dd0d1 to c1284aa Compare November 29, 2022 07:07
@stffabi stffabi marked this pull request as ready for review November 29, 2022 07:08
@stffabi stffabi force-pushed the feature/assetserver-directory-index-files branch from c1284aa to 1588519 Compare November 29, 2022 08:27
@stffabi stffabi merged commit 993f87a into wailsapp:master Nov 29, 2022
@stffabi stffabi deleted the feature/assetserver-directory-index-files branch November 29, 2022 08:29
@stffabi
Copy link
Collaborator Author

stffabi commented Nov 29, 2022

Thanks for approving 🙏

@mholt
Copy link
Contributor

mholt commented Nov 29, 2022

Thank you again for doing this :) I am hoping to catch up to it this week!

Really appreciate all you both do to work on this project 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev build uses ExternalAssetHandler, but production build does not?
3 participants