-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[assetserver] Add support for serving the index.html file when requesting a directory #2110
[assetserver] Add support for serving the index.html file when requesting a directory #2110
Conversation
Ohh, very nice. I'll give this a try! |
e1579d4
to
90957ff
Compare
@mholt Just wanted to ask if you eventually found time to give this a try? |
@stffabi Sorry for the wait! 😓 I haven't been available much with the holiday and such this week. Thanksgiving is a very big day in the US that disrupts nearly the whole week. I'll try to look at this soon. (Don't wait on me though, if you want to merge it in sooner, I don't want to be a blocker.) |
I’m sorry, I really didn’t want to stress you. |
90957ff
to
05dd0d1
Compare
Thanks for doing this - this is great! I'm going to open a new ticket that I'll do after this has been merged to update the default |
05dd0d1
to
c1284aa
Compare
c1284aa
to
1588519
Compare
Thanks for approving 🙏 |
Thank you again for doing this :) I am hoping to catch up to it this week! Really appreciate all you both do to work on this project 🙏 |
Furthermore this PR improves some error messages for the AssetServer Options and adds some additional checks.
Fixes #2109