Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Prevent a thin white line at the bottom of a frameless window #2111

Merged

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Nov 19, 2022

This seems to be only a problem on some Windows versions.

Fixes #2108

@leaanthony
Copy link
Member

Nice one! How did you figure that one out?

@stffabi stffabi force-pushed the bugfix/thin-white-line-frameless-windows branch 2 times, most recently from 8a578b9 to 09e6765 Compare November 22, 2022 09:14
@stffabi stffabi changed the title [windows] Mitigate a small white bottom line in frameless mode [windows] Prevent a small white bottom line in frameless mode Nov 22, 2022
@stffabi stffabi changed the title [windows] Prevent a small white bottom line in frameless mode [windows] Prevent a thin white line at the bottom of a frameless windows Nov 22, 2022
@stffabi stffabi marked this pull request as ready for review November 22, 2022 09:15
@stffabi stffabi enabled auto-merge (squash) November 22, 2022 09:16
@stffabi
Copy link
Collaborator Author

stffabi commented Nov 22, 2022

I think we are good to go, the author of the issue successfully tested it.

This seems to be only a problem on some Windows versions.
@stffabi stffabi force-pushed the bugfix/thin-white-line-frameless-windows branch from 09e6765 to 7d81d54 Compare November 22, 2022 09:17
@stffabi stffabi changed the title [windows] Prevent a thin white line at the bottom of a frameless windows [windows] Prevent a thin white line at the bottom of a frameless window Nov 22, 2022
@stffabi stffabi enabled auto-merge (squash) November 22, 2022 09:17
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🚀

@stffabi stffabi merged commit 72aef80 into wailsapp:master Nov 22, 2022
@stffabi
Copy link
Collaborator Author

stffabi commented Nov 22, 2022

Thanks for approving 🙏

@stffabi stffabi deleted the bugfix/thin-white-line-frameless-windows branch November 22, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected white border occured in the bottom of window when frameless is set true
2 participants