fix: fix go test errors
#2169
Merged
fix: fix go test errors
#2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misitebao
commented
Dec 3, 2022
| @@ -38,7 +38,7 @@ type Project struct { | |||
| /*** Internal Data ***/ | |||
|
|
|||
| // The path to the project directory | |||
| Path string | |||
| Path string `json:"projectdir"` | |||
There was a problem hiding this comment.
@leaanthony The modification here is so that the test case can run normally, but I don't know if it will affect other code operations.
leaanthony
approved these changes
Dec 4, 2022
|
I've pushed a couple of changes to see if it would fix the linker errors and it does appear to be fixed. Thoughts? |
I think it's ok to merge. |
leaanthony
approved these changes
Dec 5, 2022
|
Good job!! |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most errors are caused by missing
//go:build windowsbuild tags.Fatal errors during testing have been fixed, but there are still some use cases that don't pass the test.