go vet cleanup - #2182
Merged
Merged
Conversation
Deploying with
|
| Latest commit: |
c951628
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f92d15c.wails.pages.dev |
| Branch Preview URL: | https://feature-govet-cleanup.wails.pages.dev |
leaanthony
reviewed
Dec 5, 2022
leaanthony
left a comment
leaanthony
left a comment
Member
There was a problem hiding this comment.
Thanks for this @tmclane . Did go vet add in the +build lines as I believe they've been deprecated as of 1.18
Contributor
Author
|
Ah I forgot we weren't supporting older Go versions any longer. |
pkg/menu/styledlabel.go:255:2: unreachable code
tmclane
force-pushed
the
feature/govet-cleanup
branch
from
December 5, 2022 20:00
1bf9aee to
c951628
Compare
leaanthony
reviewed
Dec 5, 2022
leaanthony
left a comment
leaanthony
left a comment
Member
There was a problem hiding this comment.
That reduced it down to 1 line! Do you know why the return was removed?
Contributor
Author
|
Because of the |
Contributor
Author
|
I am thinking that perhaps leaving the final return and updating the |
Member
|
It's hard to review on mobile 😅 |
Member
|
I think it's ok as is 👍 |
leaanthony
approved these changes
Dec 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to remove only one line of
unreachablecode.