-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go vet cleanup #2182
go vet cleanup #2182
Conversation
Deploying with
|
Latest commit: |
c951628
|
Status: | ✅ Deploy successful! |
Preview URL: | https://4f92d15c.wails.pages.dev |
Branch Preview URL: | https://feature-govet-cleanup.wails.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @tmclane . Did go vet add in the +build
lines as I believe they've been deprecated as of 1.18
Ah I forgot we weren't supporting older Go versions any longer. |
pkg/menu/styledlabel.go:255:2: unreachable code
1bf9aee
to
c951628
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That reduced it down to 1 line! Do you know why the return was removed?
Because of the |
I am thinking that perhaps leaving the final return and updating the |
It's hard to review on mobile 😅 |
I think it's ok as is 👍 |
Updated to remove only one line of
unreachable
code.