Add dummy systray_mac to fix unit tests #2187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks so much for taking your time to fix this 🙏. LGTM, just a little comment: |
|
Will do it tonight |
|
I'll handle the Linux fix in a different PR 👍 |
stffabi
approved these changes
Dec 10, 2022
|
Thanks again for taking your time fixing this 🙏 |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests are broken after b84a2e5 because it has build restriction only for windows.
This PR is fixing tests for MacOS by adding Systray structure that will produce NotImplemented error if someone try to use it on Mac; however it still be buildable and testable.