Skip to content

[webview2loader] Promote go loader from experimental to stable #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Dec 13, 2022

Default webview2loader is now the go loader

@stffabi stffabi requested a review from leaanthony December 13, 2022 07:47
@stffabi stffabi enabled auto-merge (squash) December 13, 2022 07:48
@stffabi stffabi force-pushed the feature/go-webview2-loader-default branch from 8ae5570 to 7fd2f6d Compare December 13, 2022 08:41
Default webview2loader is now the go loader
@stffabi stffabi force-pushed the feature/go-webview2-loader-default branch from 7fd2f6d to e7a9de4 Compare December 13, 2022 08:46
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo, otherwise LGTM

tags = append(tags, expWebView2Loader)
message = fmt.Sprintf("An experimental Go native WebView2Loader is available. We would love to hear your feedback about it and invite you to test it by building with `-tags %s`", strings.Join(tags, ","))
tags = append(tags, nativeWebView2Loader)
message := fmt.Sprintf("Wails is now using th new Go WebView2Loader. If you encounter any issues with it, please report them to https://github.com/wailsapp/wails/issues/2004. You could also use the old legacy loader with `-tags %s`, but keep in mind this will be deprecated in the near future.", strings.Join(tags, ","))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in 5th word.

@stffabi stffabi merged commit 4aab1e6 into wailsapp:master Dec 13, 2022
@leaanthony
Copy link
Member

Oh didn't notice auto merge was on ☺️

@stffabi stffabi deleted the feature/go-webview2-loader-default branch December 13, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants