Add nosyncgomod flag #2215
Merged
Add nosyncgomod flag #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry for the late reply. Been down with the flu for a few days! I will try this out ASAP, but I also don't want you to be blocked by me while I catch up with things. The previous patch that disables syncing implicitly based on a revision/non-tagged commit works well for me, and it looks like this patch simply adds an explicit CLI flag to forcefully disable syncing. If that's right, then I think this is great too. At a glance it doesn't look like it would break anything, at least for my use case. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to not having the go.mod synced to your wails CLI version. It fixes the tests on master.
@mholt - could you please confirm this works for you? Adding
-nosyncgomodtodevorbuildshould trigger it 👍