Skip to content

[darwin] Add support for Request/Response streaming - #2219

Merged
stffabi merged 4 commits into
wailsapp:masterfrom
stffabi:feature/macos-response-streaming
Dec 20, 2022
Merged

stffabi merged 4 commits into
wailsapp:masterfrom
stffabi:feature/macos-response-streaming

Conversation

@stffabi

@stffabi stffabi commented Dec 19, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@stffabi
stffabi requested a review from leaanthony December 19, 2022 08:01
@stffabi
stffabi force-pushed the feature/macos-response-streaming branch 2 times, most recently from a5dca50 to 9ad5b33 Compare December 19, 2022 19:10

@leaanthony leaanthony left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just a question on the docs update 😄

| Request Headers | ✅ | ✅ | ✅ [^1] |
| Request Body | ✅ | ✅ | ❌ |
| Request Body Streaming | ❌ | ❌ | ❌ |
| Request Body Streaming | ✅ | ✅ | ❌ |

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was Windows updated as well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already supported that on Windows for quite some time. Just the docs wasn't updated 😄

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Response Streaming for Windows will come soon 😄

@stffabi
stffabi force-pushed the feature/macos-response-streaming branch from 9ad5b33 to 6890209 Compare December 20, 2022 12:18
@stffabi
stffabi merged commit a312c0f into wailsapp:master Dec 20, 2022
@stffabi
stffabi deleted the feature/macos-response-streaming branch December 20, 2022 12:44
@stffabi

stffabi commented Dec 20, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for approving 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants