Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnableFraudulentWebsiteDetection to options #2269

Merged

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Jan 3, 2023

This allows to explicitly opt-in to scan services for fraudulent
content, such as malware or phishing attempts.

Fixes #2163

@stffabi stffabi requested a review from leaanthony January 3, 2023 22:35
@stffabi
Copy link
Collaborator Author

stffabi commented Jan 3, 2023

@leaanthony do you think it should be opt-in or opt-out? I tend it to be opt-in but that will change the behaviour of existing apps.

Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leaanthony
Copy link
Member

leaanthony commented Jan 4, 2023

@leaanthony do you think it should be opt-in or opt-out? I tend it to be opt-in but that will change the behaviour of existing apps.

I think it should not change behaviour for v2 so that it doesn't break anything and for v3 we can change the default.

@stffabi stffabi force-pushed the feature/fraudulentwarning-optin branch from 2e918e1 to 8cf54fc Compare January 4, 2023 11:52
@stffabi
Copy link
Collaborator Author

stffabi commented Jan 4, 2023

I've updated the PR to invert the logic. @leaanthony would you mind taking another look?

@stffabi stffabi changed the title Add EnableFraudulentWebsiteWarnings to options Add DisableFraudulentWebsiteDetection to options Jan 4, 2023
@leaanthony
Copy link
Member

I had a think about this overnight.... I don't recall anyone reporting this warning so maybe disabling by default is actually fine?

This allows to explicitly opt-in to scan services for fraudulent
content, such as malware or phishing attempts.
@stffabi stffabi force-pushed the feature/fraudulentwarning-optin branch from 8cf54fc to 22f51da Compare January 5, 2023 09:44
@stffabi stffabi changed the title Add DisableFraudulentWebsiteDetection to options Add EnableFraudulentWebsiteDetection to options Jan 5, 2023
@stffabi
Copy link
Collaborator Author

stffabi commented Jan 5, 2023

Reverted back to the original version.

@leaanthony
Copy link
Member

Nice one! Thanks for doing that 🙏

@leaanthony leaanthony merged commit 284e20a into wailsapp:master Jan 5, 2023
@stffabi stffabi deleted the feature/fraudulentwarning-optin branch January 5, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable SmartScreen / FraudulentWebsite detection
2 participants