Skip to content

[windows] Improve fullscreen mode for frameless windows#2279

Merged
stffabi merged 3 commits into
wailsapp:masterfrom
stffabi:bugfix/windows-frameless-fullscreen
Jan 9, 2023
Merged

[windows] Improve fullscreen mode for frameless windows#2279
stffabi merged 3 commits into
wailsapp:masterfrom
stffabi:bugfix/windows-frameless-fullscreen

Conversation

@stffabi

@stffabi stffabi commented Jan 8, 2023

Copy link
Copy Markdown
Contributor
  • In fullscreen the taskbar was not fully covered when previously maximized
  • Unfullscreen did not correctly relayout the content
  • Prevent Unmaximise/Unminimise when in fullscreen mode
  • Use POPUP style for fullscreen mode

Fixes #2285

@stffabi stffabi force-pushed the bugfix/windows-frameless-fullscreen branch 3 times, most recently from 77f4e8b to 564efb1 Compare January 9, 2023 08:46
@stffabi stffabi changed the title [windows] Fix fullscreen mode for frameless windows and set window background colour [windows] Improve fullscreen mode for frameless windows Jan 9, 2023
@stffabi stffabi force-pushed the bugfix/windows-frameless-fullscreen branch from ecc4519 to a00490f Compare January 9, 2023 10:38
@stffabi stffabi marked this pull request as ready for review January 9, 2023 10:38
@stffabi stffabi requested a review from leaanthony January 9, 2023 10:38
- In fullscreen the taskbar was not fully covered when previously maximized
- Unfullscreen did not correctly relayout the content
- Prevent Unmaximise/Unminimise when in fullscreen mode
- Use POPUP style for fullscreen mode
@stffabi stffabi force-pushed the bugfix/windows-frameless-fullscreen branch from a00490f to b246f40 Compare January 9, 2023 10:50

@leaanthony leaanthony left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stffabi stffabi merged commit 8e4606d into wailsapp:master Jan 9, 2023
@stffabi stffabi deleted the bugfix/windows-frameless-fullscreen branch January 9, 2023 11:15
@stffabi

stffabi commented Jan 9, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frameless window Fullscreen mode issue in windows 10

2 participants