[runtime] Improve --wails-draggable by starting a drag immediately but only for the first click in a series - #2302
Merged
Conversation
stffabi
changed the title
--wails-draggable by starting a drag immediately but only for the first click in a series
stffabi
force-pushed
the
feature/improve-dragging
branch
from
January 15, 2023 19:11
7518ff8 to
4d9d2fd
Compare
stffabi
marked this pull request as ready for review
January 15, 2023 20:04
Contributor
Author
|
This doesn't work well on Linux, double click events really often get swallowed. So the previous solution did work far better on Linux. I'll update the PR to use the old solution conditionally depending on the platform. |
stffabi
marked this pull request as draft
January 16, 2023 08:08
stffabi
force-pushed
the
feature/improve-dragging
branch
from
January 16, 2023 08:43
4d9d2fd to
2dcc929
Compare
stffabi
marked this pull request as ready for review
January 16, 2023 08:44
Contributor
Author
|
Updated version pushed which defers the drag to |
…ut only for the first click in a series This removes the sometime lagging experience when starting to drag on Windows. But it's still possible to use double-click events for adding e.g. a WindowToggleMaximise.
stffabi
force-pushed
the
feature/improve-dragging
branch
from
January 16, 2023 09:54
2dcc929 to
6b5381d
Compare
stffabi
enabled auto-merge (squash)
January 16, 2023 09:54
leaanthony
approved these changes
Jan 16, 2023
leaanthony
left a comment
leaanthony
left a comment
Member
There was a problem hiding this comment.
Awesome! Absolute beast mode!
This will get easier when we split the JS to the different platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the sometime lagging experience when starting to drag on Windows. But it's still possible to use double-click events for adding e.g. a WindowToggleMaximise.
Tested on: