[dev] Fix panic in devserver when using the logger #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stffabi
force-pushed
the
bugfix/devserver-log-panic
branch
from
9f0bdfe to
2cbbd00
Compare
|
I think this is a good candidate for a 4.0.1 release. Happy to do that once @mholt confirms. |
|
I've been having trouble reproducing the bug in the first place, so... I can keep trying to produce some sort of error to be logged, but I'd personally trust @stffabi here 😅 |
leaanthony
approved these changes
Mar 13, 2023
|
Thanks for doing this @stffabi ! I think we can hold off a release unless someone else raises it. |
|
Yeah we can do that 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2480