[windows] Allow single-clicks on wails-draggable items #2482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with
|
| Latest commit: |
1ab07b4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e79b5ad3.wails.pages.dev |
| Branch Preview URL: | https://feature-deferdrag-windows-ol.wails.pages.dev |
|
This is great!! I can confirm that this works on Windows and does not break the behavior on Linux. 🎉 🥳 Edit: But removing the line of code setting it to true does cause Windows to require a double-click now :( |
stffabi
changed the title
…ith window.wails.flags.deferDragToMouseMove
This enhanced version should work well in all cases for Windows: - No lag/delayed start of dragging - Double-Clicks and Single-Click events still work in JavaScript on elements
stffabi
force-pushed
the
feature/deferdrag-windows-old-behaviour
branch
from
239a2e8 to
1ab07b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically reverts parts of #2302 by using the "defer to mouse move" mode but to an enhanced version that should does not lag/delay the dragging on Windows.
Fixes #2471