Skip to content

Feature/v3 parser: expand TS model generation tests & some fixes #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 22, 2023
Merged

Feature/v3 parser: expand TS model generation tests & some fixes #2485

merged 10 commits into from
Mar 22, 2023

Conversation

ATenderholt
Copy link
Contributor

Several test cases aren't generating Models.

@vercel
Copy link

vercel bot commented Mar 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
wails-v3-docs ❌ Failed (Inspect) Mar 14, 2023 at 2:43AM (UTC)

@leaanthony
Copy link
Member

Nice! Thanks for this! Make sure you update the changeling with your contribution 👍

@leaanthony
Copy link
Member

FYI: Some of the tests won't generate models but that's expected. It only generates models for structs that are used in bound methods.

@ATenderholt
Copy link
Contributor Author

Nice! Thanks for this! Make sure you update the changeling with your contribution 👍

Is this what you meant? f429d2b

Things like CHANGELOG.md, etc. just had links.

@leaanthony
Copy link
Member

leaanthony commented Mar 13, 2023 •
edited
Loading

Oh my bad, I meant CHANGELOG.mdx in the website directory. I'll update the CHANGELOG in the root directory to point to there if it doesn't already. You should already be in the all-contributors file...

@ATenderholt
Copy link
Contributor Author

Oh my bad, I meant CHANGELOG.mdx in the website directory. I'll update the CHANGELOG in the root directory to point to there if it doesn't already. You should already be in the all-contributors file...

How's this? 8064b12

@leaanthony leaanthony merged commit 536ae4c into wailsapp:feature/v3-parser Mar 22, 2023
@leaanthony
Copy link
Member

Awesome work @ATenderholt !

leaanthony pushed a commit that referenced this pull request Mar 24, 2023
@ATenderholt @leaanthony
Feature/v3 parser: expand TS model generation tests & some fixes (#2485)
130fab6 
* v3 parser: add tests for model generation

* v3 parser: use single quotes for got model.ts

* v3 parser: fixes for some failing tests

* v3 parser: misc simplification and cleanup

* v3 parser: fix model tests when no structs returned

* v3 parser: fix last failing test case

* Update contributors list

* v3 parser: update README

* Revert "Update contributors list"

This reverts commit f429d2b.

* Changelog: add line about my contribution
@ATenderholt ATenderholt deleted the feature/v3-parser branch March 26, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leaanthony leaanthony leaanthony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ATenderholt @leaanthony