Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2, darwin] Add some missing default shortcuts #2586

Merged
merged 3 commits into from
Apr 20, 2023

Conversation

stffabi
Copy link
Collaborator

@stffabi stffabi commented Apr 12, 2023

See also #2582

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fdbe3dd
Status: ✅  Deploy successful!
Preview URL: https://b60793dc.wails.pages.dev
Branch Preview URL: https://feature-darwin-shortcuts.wails.pages.dev

View logs

@mholt
Copy link
Contributor

mholt commented Apr 17, 2023

From my brief testing, this works! Thank you!

This also includes shortcuts support for those commands.
Arrange the menu items in the well known MacOS order.
@stffabi stffabi marked this pull request as ready for review April 18, 2023 05:41
@stffabi stffabi requested a review from leaanthony April 18, 2023 05:41
Copy link
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm wondering at a later stage whether we add the Window menu only if frameless is false in appoptions.

@stffabi stffabi merged commit 0bf4109 into master Apr 20, 2023
@stffabi stffabi deleted the feature/darwin-shortcuts branch April 20, 2023 10:38
leaanthony pushed a commit that referenced this pull request Apr 26, 2023
* [v2, darwin] Add "Hide, Hide Others, Show All“ to appmenu

This also includes shortcuts support for those commands.
Arrange the menu items in the well known MacOS order.

* [v2, darwin] Add Window menu with well known shortcuts Minimize, Full-Screen and Zoom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants