Skip to content

[v2, darwin] Add some missing default shortcuts#2586

Merged
stffabi merged 3 commits into
masterfrom
feature/darwin-shortcuts
Apr 20, 2023
Merged

[v2, darwin] Add some missing default shortcuts#2586
stffabi merged 3 commits into
masterfrom
feature/darwin-shortcuts

Conversation

@stffabi
Copy link
Copy Markdown
Contributor

@stffabi stffabi commented Apr 12, 2023

See also #2582

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Apr 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fdbe3dd
Status: ✅  Deploy successful!
Preview URL: https://b60793dc.wails.pages.dev
Branch Preview URL: https://feature-darwin-shortcuts.wails.pages.dev

View logs

@mholt
Copy link
Copy Markdown
Contributor

mholt commented Apr 17, 2023

From my brief testing, this works! Thank you!

stffabi added 2 commits April 18, 2023 07:37
This also includes shortcuts support for those commands.
Arrange the menu items in the well known MacOS order.
@stffabi stffabi force-pushed the feature/darwin-shortcuts branch from 481c32d to 682c08d Compare April 18, 2023 05:37
@stffabi stffabi marked this pull request as ready for review April 18, 2023 05:41
@stffabi stffabi requested a review from leaanthony April 18, 2023 05:41
Copy link
Copy Markdown
Member

@leaanthony leaanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm wondering at a later stage whether we add the Window menu only if frameless is false in appoptions.

@stffabi stffabi merged commit 0bf4109 into master Apr 20, 2023
@stffabi stffabi deleted the feature/darwin-shortcuts branch April 20, 2023 10:38
leaanthony pushed a commit that referenced this pull request Apr 26, 2023
* [v2, darwin] Add "Hide, Hide Others, Show All“ to appmenu

This also includes shortcuts support for those commands.
Arrange the menu items in the well known MacOS order.

* [v2, darwin] Add Window menu with well known shortcuts Minimize, Full-Screen and Zoom.
Grantmartin2002 pushed a commit to Grantmartin2002/wails that referenced this pull request Apr 29, 2026
* [v2, darwin] Add "Hide, Hide Others, Show All“ to appmenu

This also includes shortcuts support for those commands.
Arrange the menu items in the well known MacOS order.

* [v2, darwin] Add Window menu with well known shortcuts Minimize, Full-Screen and Zoom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants