Skip to content

set the background color for window - #2853

Merged
leaanthony merged 2 commits into
wailsapp:masterfrom
lyimmi:bugfix/2852_window_background_color_not_set
Aug 24, 2023
Merged

leaanthony merged 2 commits into
wailsapp:masterfrom
lyimmi:bugfix/2852_window_background_color_not_set

Conversation

@lyimmi

@lyimmi lyimmi commented Aug 24, 2023 •

Copy link
Copy Markdown
Contributor

Description

With this PR the SetBackgroundColour function sets the window's and the webview's background color as well. To make the resize flickering less prominent.

Fixes #2852

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested it on existing and new projects, set the color from go and javascript.

  • Windows
  • macOS
  • Linux

Test Configuration

# System

OS           | Ubuntu  
Version      | 23.04   
ID           | ubuntu  
Go Version   | go1.21.0
Platform     | linux   
Architecture | amd64   

# Wails

Version         | v2.5.1
Package Manager | apt   

# Dependencies

Dependency | Package Name          | Status    | Version                
*docker    | docker.io             | Installed | 24.0.5                 
gcc        | build-essential       | Installed | 12.9ubuntu3            
libgtk-3   | libgtk-3-dev          | Installed | 3.24.37-1ubuntu1       
libwebkit  | libwebkit2gtk-4.0-dev | Installed | 2.40.5-0ubuntu0.23.04.1
npm        | npm                   | Installed | 9.8.0                  
*nsis      | nsis                  | Installed | v3.08-3                
pkg-config | pkg-config            | Installed | 1.8.1-1ubuntu2

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@lyimmi
lyimmi marked this pull request as ready for review August 24, 2023 22:10

@leaanthony leaanthony left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @lyimmi 🙏🔥

@leaanthony
leaanthony merged commit 5a4eae9 into wailsapp:master Aug 24, 2023
@lyimmi
lyimmi deleted the bugfix/2852_window_background_color_not_set branch August 24, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[V2, Linux] Window background color not set

2 participants