Skip to content

[v2 mac] add fullscreen option to preference #2953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

fkhadra
Copy link
Contributor

@fkhadra fkhadra commented Sep 29, 2023

Description

This PR adds the option to enable/disable fullscreen support on Mac. For example, when this option is enabled, it allows the user to display a video in fullscreen mode.

Fixes # 2099

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

I've created a new wails app that point to my changes. The app only render a video. When the user hover the video a fullscreen button is displayed allowing the user to switch in fullscreen mode.

wails-fs.mp4

Repository: https://github.com/fkhadra/wails-fix-2099

  • Windows
  • macOS
  • Linux

Test Configuration

# Wails
Version | v2.6.0

# System
┌─────────────────────────┐
| OS           | MacOS    |
| Version      | 13.5.2   |
| ID           | 22G91    |
| Go Version   | go1.21.0 |
| Platform     | darwin   |
| Architecture | arm64    |
└─────────────────────────┘

# Dependencies
┌──────────────────────────────────────────────────────────────────┐
| Dependency                | Package Name | Status    | Version   |
| Xcode command line tools  | N/A          | Installed | 2397      |
| Nodejs                    | N/A          | Installed | 18.17.0   |
| npm                       | N/A          | Installed | 9.6.7     |
| *Xcode                    | N/A          | Available |           |
| *upx                      | N/A          | Installed | upx 4.1.0 |
| *nsis                     | N/A          | Available |           |
└──────────────────── * - Optional Dependency ─────────────────────┘

# Diagnosis
Optional package(s) installation details:
  - Xcode: Available at https://apps.apple.com/us/app/xcode/id497799835
  - nsis : More info at https://wails.io/docs/guides/windows-installer/

 SUCCESS  Your system is ready for Wails development!

 ♥   If Wails is useful to you or your company, please consider sponsoring the project:
https://github.com/sponsors/leaanthony

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gofmt should clean these up for you

@fkhadra
Copy link
Contributor Author

fkhadra commented Oct 1, 2023

Actually, the indention on the IDE was ok but I was using space instead of tab, thanks for pointing out.

Screenshot 2023-10-01 at 19 08 50

@leaanthony leaanthony merged commit f6c82dc into wailsapp:master Oct 1, 2023
@leaanthony
Copy link
Member

Thanks @fkhadra 🙏

@fkhadra
Copy link
Contributor Author

fkhadra commented Oct 1, 2023

You're welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants